feat(intl): implement Temporal.PlainYearMonth.prototype.toLocaleString#5098
Open
alienx5499 wants to merge 3 commits intoboa-dev:mainfrom
Open
feat(intl): implement Temporal.PlainYearMonth.prototype.toLocaleString#5098alienx5499 wants to merge 3 commits intoboa-dev:mainfrom
alienx5499 wants to merge 3 commits intoboa-dev:mainfrom
Conversation
github-actions
bot
added
Waiting On Review
Test262 conformance changes
Fixed tests (1):Tested main commit: |
This was referenced Mar 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5098 +/- ##
===========================================
+ Coverage 47.24% 59.85% +12.61%
===========================================
Files 476 582 +106
Lines 46892 63445 +16553
===========================================
+ Hits 22154 37977 +15823
- Misses 24738 25468 +730 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alienx5499
force-pushed
the
feat/5083-plainyearmonth-tolocalestring
branch
from
f11323d to
fceb44a
Compare
github-actions
bot
added
the
Waiting On Review
alienx5499
requested review from
a team,
jasonwilliams,
jedel1043 and
nekevss
as code owners
nekevss
requested changes
Mar 20, 2026
| Ok(JsString::from(year_month.inner.to_string()).into()) | ||
| #[cfg(feature = "intl")] | ||
| { | ||
| use crate::builtins::{ |
Member
There was a problem hiding this comment.
issue: the implementation here should ideally follow or adapt the specification steps provided in the Temporal specification as additions to ECMA402
Test262 conformance changes
Fixed tests (1):Broken tests (1):Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5083.
It changes the following:
Temporal.PlainYearMonth.prototype.toLocaleStringper spec, using the sharedformat_date_time_localepipeline (same pattern asDate.prototype.toLocaleDateString).HandleDateTimeTemporalYearMonthplumbing to compute the Intl formatting anchor from the Temporal plain value; validate Intlcalendaragainst the Temporal calendar, and model Temporal plaintimeZoneby forcing IntltimeZoneto"+00:00".PlainYearMonth.prototype.toLocaleString: returns string, invalid receiver throwsTypeError, and (with theintlfeature) different locales/options affect output; plaintimeZoneis ignored/overridden and incompatiblecalendarthrows.Testing
cargo test -p boa_engine --no-default-features --features temporal --lib plain_year_month(Temporal-only tests)cargo test -p boa_engine --features intl_bundled,temporal --lib plain_year_month(with intl)Status: rebased onto
mainafter #5080; this PR now only contains the TemporalPlainYearMonth.prototype.toLocaleStringchanges for #5083.